admin/sides
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(reliability): resolve F-11 — add required parameter validation to historical endpoints

Browse Source
This commit is contained in:
root
2026-05-28 16:34:52 +08:00
parent 509afdb4c8
commit f9061ade2f
2 changed files with 32 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/app/Http/Controllers/RainfallController.php
View File

@@ -301,9 +301,15 @@ class RainfallController extends Controller
// Function for Retrieve Historical Rainfall Data // Function for Retrieve Historical Rainfall Data
public function historicalRainfall(Request $request) public function historicalRainfall(Request $request)
{ {
$stationFilter = $request->get('station'); $validated = $request->validate([
$startDateInput = $request->input('startdate'); 'station' => 'required|string|max:20',
$endDateInput = $request->input('enddate'); 'startdate' => 'required|date',
'enddate' => 'required|date|after_or_equal:startdate',
]);
$stationFilter = $validated['station'];
$startDateInput = $validated['startdate'];
$endDateInput = $validated['enddate'];
$displayDate = $startDateInput ?: now(); $displayDate = $startDateInput ?: now();
$displayEndDate = $endDateInput ?: now(); $displayEndDate = $endDateInput ?: now();
@@ -368,9 +374,15 @@ class RainfallController extends Controller
// Function for export Historical Rainfall To Excel File // Function for export Historical Rainfall To Excel File
public function exportHourlyRainfallExcel(Request $request) public function exportHourlyRainfallExcel(Request $request)
{ {
$stationid = $request->get('station'); $validated = $request->validate([
$startDate = $request->input('startdate'); 'station' => 'required|string|max:20',
$endDate = $request->input('enddate'); 'startdate' => 'required|date',
'enddate' => 'required|date|after_or_equal:startdate',
]);
$stationid = $validated['station'];
$startDate = $validated['startdate'];
$endDate = $validated['enddate'];
$startDate2 = Carbon::parse($startDate)->toDateString(); $startDate2 = Carbon::parse($startDate)->toDateString();

18
src/app/Http/Controllers/WaterLevelController.php
View File

@@ -80,8 +80,13 @@ class WaterLevelController extends Controller
// Function Retrieve Water Level Historical Data // Function Retrieve Water Level Historical Data
public function wlHistory(Request $request) public function wlHistory(Request $request)
{ {
$stationid = $request->get('station'); $validated = $request->validate([
$startDate = $request->input('startdate'); 'station' => 'required|string|max:20',
'startdate' => 'required|date',
]);
$stationid = $validated['station'];
$startDate = $validated['startdate'];
$stations = DB::table('station')->select('stationid','name') $stations = DB::table('station')->select('stationid','name')
@@ -122,8 +127,13 @@ class WaterLevelController extends Controller
// Function export historical water level data // Function export historical water level data
public function exportHistoricalWl(Request $request) public function exportHistoricalWl(Request $request)
{ {
$stationid = $request->get('station'); $validated = $request->validate([
$startDate = $request->input('startdate'); 'station' => 'required|string|max:20',
'startdate' => 'required|date',
]);
$stationid = $validated['station'];
$startDate = $validated['startdate'];
$startDate2 = Carbon::parse($startDate)->toDateString(); $startDate2 = Carbon::parse($startDate)->toDateString();